-
Notifications
You must be signed in to change notification settings - Fork 2
feat: modify prompt style and icon #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.vitepress/theme/style.css(2 hunks)
🔇 Additional comments (1)
.vitepress/theme/style.css (1)
493-505: Define icon content for remaining custom-block variants.The
::beforepseudo-element is styled for all custom-block types (lines 493–502), but content is specified only for the info variant (lines 503–505). The warning, danger, and tip blocks will render the icon box but with no visible content. Add missing icon content, or clarify if this is intentional.Are warning, danger, and tip blocks intended to display icons? If so, add corresponding content definitions:
.vp-doc .custom-block.info::before { content: url("../../public/icon-app.svg"); } +.vp-doc .custom-block.warning::before { + content: url("../../public/icon-warning.svg"); +} +.vp-doc .custom-block.danger::before { + content: url("../../public/icon-danger.svg"); +} +.vp-doc .custom-block.tip::before { + content: url("../../public/icon-tip.svg"); +}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (2)
.vitepress/theme/style.css (2)
507-507: Comment syntax issue appears resolved.This line was previously flagged for containing a stray 'r' after the closing
*/. The current code shows the comment is now properly formatted, so the CSS parsing issue should be resolved.
640-644: Fix dark mode warning block text color visibility.Line 643 specifies the warning text color as
rgba(255, 136, 0, 0.1), which has 10% opacity and renders text nearly invisible. This issue was flagged in the previous review. The light mode warning uses solid color#79350f, and other dark mode block variants use opaque colors. Align the dark mode warning to use a visible, readable color.Apply this diff to fix the text color:
.dark .vp-doc .custom-block.warning{ background: rgba(255, 183, 0, 0.1); border: 1px solid rgba(255, 183, 0, 0.2); - color: rgba(255, 136, 0, 0.1); + color: #ffb700; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.vitepress/theme/style.css(2 hunks)
🔇 Additional comments (1)
.vitepress/theme/style.css (1)
458-505: Light mode custom-block styling looks good.The flex layout, typography, and color schemes are well-designed with appropriate contrast. The ::before pseudo-element setup is consistent with existing header anchor and outline title patterns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
♻️ Duplicate comments (1)
.vitepress/theme/style.css (1)
650-654: Fix dark mode warning block text color visibility.Line 653 specifies
color: rgba(255, 136, 0, 0.1)(10% opacity), rendering text nearly invisible. This issue was flagged in a prior review but remains unfixed.Apply this diff to use a solid, visible color:
.dark .vp-doc .custom-block.warning{ background: rgba(255, 183, 0, 0.1); border: 1px solid rgba(255, 183, 0, 0.2); - color: rgba(255, 136, 0, 0.1); + color: #ffb700; }
Summary by CodeRabbit