Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search option for items under walls/windows/doors #63

Merged
merged 10 commits into from
Jun 3, 2024

Conversation

luanluciano93
Copy link

  • Adicionado opção de buscar todas as posições onde há paredes/janelas/portas sobre paredes/janelas/portas no mapa todo e por área selecionada.

(Testado no mapa otservbr 3.0.0)
image

image

@dudantas dudantas changed the title feat: option search all positions where there are walls/windows/doors upon walls/windows/doors feat: search option for items on walls/windows/doors Nov 22, 2023
@dudantas dudantas changed the title feat: search option for items on walls/windows/doors feat: search option for items under walls/windows/doors Nov 22, 2023
@dudantas
Copy link

dudantas commented Nov 28, 2023

Tem alguns checks do sonar para arrumar... Alguns são até bem simples, se quiser dar uma olhada. Os que não conseguir, me avisa que eu vejo. Mas, preciso de acesso write no seu repositório para poder modificar arquivos.

@dudantas dudantas marked this pull request as draft November 28, 2023 14:13
@luanluciano93 luanluciano93 marked this pull request as ready for review December 1, 2023 02:35
@luanluciano93 luanluciano93 marked this pull request as draft December 1, 2023 04:45
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@luanluciano93
Copy link
Author

@dudantas os 3 que sobraram tentei corrigir, mas dão erro na compilação ...

@luanluciano93 luanluciano93 marked this pull request as ready for review December 13, 2023 02:19
Copy link

sonarcloud bot commented Jan 30, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@majestyotbr majestyotbr merged commit 6c09718 into opentibiabr:main Jun 3, 2024
6 checks passed
@luanluciano93 luanluciano93 deleted the featWallsUponWalls branch June 3, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants