Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: synchronizing commits with the official rme repository #36

Merged
merged 46 commits into from
Oct 10, 2023

Conversation

beats-dh
Copy link
Collaborator

@beats-dh beats-dh commented Apr 4, 2023

@sonarcloud
Copy link

sonarcloud bot commented Apr 9, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug D 6 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 739 Code Smells

0.0% 0.0% Coverage
4.5% 4.5% Duplication

@beats-dh beats-dh marked this pull request as ready for review April 10, 2023 16:37
@dudantas dudantas changed the title . feat: synchronizing commits with the official rme repository May 25, 2023
@Mirkaanks

This comment has been minimized.

@beats-dh

This comment has been minimized.

@sonarcloud

This comment has been minimized.

@jacques-tony
Copy link

Beats estou deixando comentado aqui para não se perder em nossa conversa, fora os pontos apontados abaixo estou usando essa pr e tem funcionado bem.

- Show indicators for pickupable and moveable items

Testado e funcionando normalmente, seria interessante se tivesse um atalho para o uso ele fica no final da lista dentro de um menu lateral.

- Fix: drawing always refreshing ui

Testado e funcionando normalmente

- Option to remove empty spawns and Add undo/redo after remove empty spawns

Testado e funcionando normalmente o spawn de NPC não tem nenhum indicativo, antes tinha um fogo laranjinha

image

- Draws position indicator

Testado e funcionando normalmente

- Avoid adding a new Unique ID if it already exists
Testado e funcionando, mas se você copiar um objeto que já tenha um unique ID ele, ele vai duplicar o unique ID

- Elementos na paleta Doodad não esta sendo possível selecionar eles com o click direito no mapa.
Agora
image (1)
Antes
image (2)

- Grid do comando SHIFT + I não esta ficando centralizado na tela, conforme o zoom vai aumentando ele vai se deslocando.

image (3)
image (4)

- Teleport copy/paste improvements
Quando se define nas configurações o terceiro tipo de "Copy Position Format - x,y,z ele não cola separado nos itens que tem o campo destination
image (5)
image (6)
GIF 07-07-2023 09-55-41

-Add function to get minimap/8bit color
Testado e funcionando normalmente

-Fix flood fill
Testado e funcionando normalmente

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 744 Code Smells

0.0% 0.0% Coverage
4.4% 4.4% Duplication

@luan luan merged commit 6b55201 into opentibiabr:main Oct 10, 2023
5 checks passed
@beats-dh beats-dh deleted the beats branch October 13, 2023 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants