This repository has been archived by the owner on May 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 162
Enable gamestore to offers services/items for tournament coins #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majestyotbr
changed the title
enable gamestore to offers services/items for tournament coins
Enable gamestore to offers services/items for tournament coins
Aug 5, 2022
majestyotbr
approved these changes
Aug 7, 2022
majestyotbr
approved these changes
Aug 7, 2022
dudantas
suggested changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions related to indentation. The code itself seems to be ok.
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
…and sendUpdateCoinBalance to sendUpdatedStoreBalances
Co-authored-by: Eduardo Dantas <eduardo.dantas@hotmail.com.br>
dudantas
approved these changes
Aug 8, 2022
majestyotbr
approved these changes
Aug 8, 2022
guispiller
approved these changes
Aug 8, 2022
JoaoCRDias
approved these changes
Aug 10, 2022
QuebradaZN
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing and apparently everything is ok!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows offers tagged with
coinType = GameStore.CointType.Tournament
to correctly charge Tournament Coins.Added correct history for the store transactions following the coin type.
Removed duplicate charge and history when changing the Name or Sex of a Hireling.
Behaviour
Actual
Buying something tagged with Tournament Coins will be charged on Tibia Coins.
Buying
Hireling Sex Change
orHireling Name Change
charges twice the amount and add two purchases to the history.Expected
Buying something tagged with Tournament Coins will be charged using Tournament Coins.
Buying
Hireling Sex Change
orHireling Name Change
charges the displayed amount and adds a single purchase to the history.Fixes
# (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested
On
data/modules/scripts/gamestore/gamestore.lua
change the line 4492 fromoffer.coinType = GameStore.CointType.Coin
tooffer.coinType = GameStore.CointType.Tournament
to change all offers to use Tournament Coins.Go inside the game and buy one of each OfferType; check history.
Test Configuration:
Checklist