Skip to content

fix: can't sell containers with items inside (#2911)

Sign in for the full log view
GitHub Actions / Qodana for C/C++ completed Sep 28, 2024 in 0s

18287 new problems found by Qodana for C/C++

Qodana for C/C++

1020 new problems were found

Inspection name Severity Problems
misra-cpp2008-5-0-11 🔶 Warning 896
err33-c 🔶 Warning 37
static-accessed-through-instance 🔶 Warning 16
misra-cpp2008-5-0-5 🔶 Warning 11
function-cognitive-complexity 🔶 Warning 6
misra-cpp2008-5-2-12 🔶 Warning 5
misra-cpp2008-4-5-2 🔶 Warning 5
narrowing-conversions 🔶 Warning 3
unnecessary-value-param 🔶 Warning 3
misra-cpp2008-0-1-7 🔶 Warning 3
implicit-bool-conversion 🔶 Warning 3
use-starts-ends-with 🔶 Warning 3
magic-numbers 🔶 Warning 3
misra-cpp2008-5-3-1 🔶 Warning 2
misra-cpp2008-5-0-13 🔶 Warning 2
container-size-empty 🔶 Warning 2
misra-cpp2008-5-0-6 🔶 Warning 2
unnecessary-copy-initialization 🔶 Warning 2
for-range-copy 🔶 Warning 2
id-dependent-backward-branch 🔶 Warning 2
duplicate-include 🔶 Warning 2
simplify-boolean-expr 🔶 Warning 2
misra-cpp2008-6-4-5 🔶 Warning 1
no-automatic-move 🔶 Warning 1
unroll-loops 🔶 Warning 1
too-small-loop-variable 🔶 Warning 1
convert-member-functions-to-static 🔶 Warning 1
pass-by-value 🔶 Warning 1
inconsistent-declaration-parameter-name 🔶 Warning 1
redundant-casting 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.11
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 30 in src/account/account.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-11 

MISRA 5-0-11: The plain char type shall only be used for the storage and use of character values

Check warning on line 38 in src/account/account.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-11 

MISRA 5-0-11: The plain char type shall only be used for the storage and use of character values

Check warning on line 471 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 756 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 1810 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 1817 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 1821 in src/creatures/creature.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 52 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 447 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 451 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 455 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 461 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 462 in src/creatures/interactions/chat.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 774 in src/lua/functions/creatures/creature_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 276 in src/lua/functions/creatures/monster/monster_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

err33-c 

the value returned by this function should not be disregarded; neglecting it may lead to errors

Check warning on line 645 in src/lua/functions/creatures/monster/monster_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-2-12 

MISRA 5-2-12: An identifier with array type passed as a function argument shall not decay to a pointer

Check warning on line 660 in src/lua/functions/creatures/monster/monster_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-2-12 

MISRA 5-2-12: An identifier with array type passed as a function argument shall not decay to a pointer

Check warning on line 673 in src/lua/functions/creatures/monster/monster_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-3-1 

MISRA 5-3-1: Each operand of the ! operator, the logical && or the logical || operators shall have type bool

Check warning on line 674 in src/lua/functions/creatures/monster/monster_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-2-12 

MISRA 5-2-12: An identifier with array type passed as a function argument shall not decay to a pointer

Check warning on line 679 in src/lua/functions/creatures/monster/monster_functions.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 114 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 119 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 122 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 129 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 132 in src/creatures/monsters/monster.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions
View more details on GitHub Actions