Skip to content

fix: store transfer history

Sign in for the full log view
GitHub Actions / Qodana for C/C++ completed Aug 21, 2024 in 0s

19226 new problems found by Qodana for C/C++

Qodana for C/C++

170 new problems were found

Inspection name Severity Problems
magic-numbers 🔶 Warning 37
implicit-bool-conversion 🔶 Warning 17
misra-cpp2008-5-0-6 🔶 Warning 15
misra-cpp2008-5-0-13 🔶 Warning 10
unroll-loops 🔶 Warning 10
unnecessary-value-param 🔶 Warning 9
qualified-auto 🔶 Warning 8
simplify-boolean-expr 🔶 Warning 6
misra-cpp2008-5-3-1 🔶 Warning 6
init-variables 🔶 Warning 5
function-cognitive-complexity 🔶 Warning 5
narrowing-conversions 🔶 Warning 4
misra-cpp2008-2-13-3 🔶 Warning 4
easily-swappable-parameters 🔶 Warning 4
misra-cpp2008-0-1-7 🔶 Warning 4
for-range-copy 🔶 Warning 3
redundant-string-init 🔶 Warning 3
misra-cpp2008-5-0-12 🔶 Warning 3
convert-member-functions-to-static 🔶 Warning 3
misra-cpp2008-5-0-5 🔶 Warning 2
redundant-casting 🔶 Warning 2
misra-cpp2008-6-4-2 🔶 Warning 2
id-dependent-backward-branch 🔶 Warning 1
unused-parameters 🔶 Warning 1
branch-clone 🔶 Warning 1
pro-type-member-init 🔶 Warning 1
readability-casting 🔶 Warning 1
make-member-function-const 🔶 Warning 1
const-return-type 🔶 Warning 1
else-after-return 🔶 Warning 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.9
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 174 in src/account/account.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

narrowing-conversions 

narrowing conversion from 'uint32_t' (aka 'unsigned int') to signed type 'int32_t' (aka 'int') is implementation-defined

Check warning on line 1367 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

magic-numbers 

0xFB is a magic number; consider replacing it with a named constant

Check warning on line 1370 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

magic-numbers 

0xFC is a magic number; consider replacing it with a named constant

Check warning on line 1373 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

magic-numbers 

0xFD is a magic number; consider replacing it with a named constant

Check warning on line 3330 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

magic-numbers 

0xEF is a magic number; consider replacing it with a named constant

Check warning on line 7590 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

magic-numbers 

0xFA is a magic number; consider replacing it with a named constant

Check warning on line 9145 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

magic-numbers 

0xFB is a magic number; consider replacing it with a named constant

Check warning on line 9193 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

qualified-auto 

'auto offer' can be declared as 'const auto *offer'

Check warning on line 9194 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

implicit-bool-conversion 

implicit conversion 'const Offer *' -> 'bool'

Check warning on line 9219 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

magic-numbers 

26 is a magic number; consider replacing it with a named constant

Check warning on line 9223 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 9223 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-5 

MISRA 5-0-5: There shall be no implicit floating-integral conversions

Check warning on line 9228 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-6 

MISRA 5-0-6: An implicit integral or floating-point conversion shall not reduce the size of the underlying type

Check warning on line 9229 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

id-dependent-backward-branch 

backward branch (for loop) is ID-dependent due to variable reference to 'entry' and may cause performance degradation

Check warning on line 9235 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

magic-numbers 

0xFD is a magic number; consider replacing it with a named constant

Check warning on line 9264 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

qualified-auto 

'auto currentCategory' can be declared as 'const auto *currentCategory'

Check warning on line 9265 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

implicit-bool-conversion 

implicit conversion 'const Category *' -> 'bool'

Check warning on line 9271 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

qualified-auto 

'auto offer' can be declared as 'const auto *offer'

Check warning on line 9273 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

qualified-auto 

'auto parentCategory' can be declared as 'const auto *parentCategory'

Check warning on line 9274 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

implicit-bool-conversion 

implicit conversion 'const Category *' -> 'bool'

Check warning on line 9341 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

implicit-bool-conversion 

implicit conversion 'bool' -> 'uint8_t' (aka 'unsigned char')

Check warning on line 9347 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

magic-numbers 

0xFC is a magic number; consider replacing it with a named constant

Check warning on line 9356 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

misra-cpp2008-5-0-6 

MISRA 5-0-6: An implicit integral or floating-point conversion shall not reduce the size of the underlying type

Check warning on line 9359 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

for-range-copy 

loop variable is copied but only used as const reference; consider making it a const reference

Check warning on line 9371 in src/server/network/protocol/protocolgame.cpp

See this annotation in the file changed.

@github-actions github-actions / Qodana for C/C++

qualified-auto 

'auto offer' can be declared as 'const auto *offer'
View more details on GitHub Actions