Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix checks on player death, player speed breakpoint and misc enhancements #378

Merged
merged 22 commits into from
Jun 24, 2022

Conversation

omeranha
Copy link
Contributor

@omeranha omeranha commented May 8, 2022

Added tag in config.lua for:

  • Max critical chance of imbuements
  • Adventurers blessing level
  • Inventory glow on five bless

Fixed:

  • Set default maxSpeed for 70000
  • Still blessed after dead for work with "no disconnect on death"
  • Player targetting after dead for work with "no disconnect on death"
  • Adventurer blessing logic for work with "no disconnect on death"

Resolves: #290
Resolves: #291
Resolves: #327
Resolves: #354
Resolves: #404

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@SRNT-GG
Copy link
Contributor

SRNT-GG commented May 9, 2022

It should say blessings not "blesses", a small nitpick but the devil's in the details!

@omeranha omeranha marked this pull request as draft May 13, 2022 10:13
@omeranha
Copy link
Contributor Author

It should say blessings not "blesses", a small nitpick but the devil's in the details!

should be good now!

@XmasGame
Copy link

it works?

@omeranha omeranha changed the title Fix checks on player death + player speed breakpoint Fix checks on player death, player speed breakpoint and misc enhancements Jun 7, 2022
Copy link
Contributor

@guispiller guispiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little fixes:
When a player dies, the message of lost blessings is showing to every online player.
If a player is with adventurer's blessing(configured in blessings.lua), after death, he needs to logout and login to receive the blessings again (issue #404).

@sonarcloud
Copy link

sonarcloud bot commented Jun 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@omeranha omeranha marked this pull request as ready for review June 24, 2022 01:10
@omeranha omeranha merged commit e5cc80a into main Jun 24, 2022
@omeranha omeranha deleted the fix-player-deaths branch June 24, 2022 01:11
luan pushed a commit that referenced this pull request Jul 11, 2023
…ents (#378)

### Added tag in config.lua for:
* Max critical chance of imbuements
* Adventurers blessing level 
* Inventory glow on five bless 

### Fixed:
* Set default maxSpeed for 70000
* Still blessed after dead for work with "no disconnect on death"
* Player targetting after dead for work with "no disconnect on death"
* Adventurer blessing logic for work with "no disconnect on death"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
8 participants