fix: add rate limiting to party analyzer updates #3728
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces a 1-second interval between party analyzer updates by tracking the next allowed update time. This prevents excessive updates and improves network efficiency.
There was a problem hiding this comment.
Pull Request Overview
Adds rate limiting to party analyzer updates to prevent excessive network requests by implementing a 1-second cooldown mechanism. This ensures updates are throttled to improve network efficiency and performance.
Key changes:
- Added a member variable to track the next allowed update time
- Implemented rate limiting logic in the update function with a 1-second interval
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/server/network/protocol/protocolgame.hpp | Added member variable to track next allowed party analyzer update time |
| src/server/network/protocol/protocolgame.cpp | Implemented rate limiting logic with 1-second cooldown in update function |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
gabrielew
approved these changes
Oct 13, 2025
libergod
approved these changes
Oct 13, 2025
Contributor
|
This PR is stale because it has been open 45 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a 1-second interval between party analyzer updates by tracking the next allowed update time. This prevents excessive updates and improves network efficiency.