Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance and refactor: multiple scripts for better functionality #3007

Merged
merged 37 commits into from
Nov 13, 2024

Conversation

omarcopires
Copy link
Contributor

@omarcopires omarcopires commented Oct 23, 2024

Description

  1. Fixes a minor issue where, when emptying the balloons, they were transformed into 255 instead of being reset to 1.
  2. Adjusts the usage of the "bathtub" in datapacks, in addition to the RLMap, ensuring better compatibility.
  3. Makes minor aesthetic changes to enhance the code's readability.

Close #2923

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@omarcopires omarcopires changed the title fix: prevent multiple transformations of anniversary balloons fix: prevent multiple transformations of anniversary balloons and others Oct 24, 2024
@omarcopires omarcopires marked this pull request as draft October 25, 2024 20:19
@omarcopires omarcopires marked this pull request as ready for review October 25, 2024 20:45
…renaming

Changes to the gold ranking script to improve readability and formatting. Variable names were renamed to be more descriptive, and the FormatNumber function was used to display balance values in a formatted way. The database query result check was adjusted for better clarity.
@omarcopires omarcopires marked this pull request as draft October 30, 2024 20:34
@omarcopires omarcopires changed the title fix: prevent multiple transformations of anniversary balloons and others enhance and refactor: multiple scripts for better functionality Oct 30, 2024
@omarcopires omarcopires force-pushed the fix-balloons branch 2 times, most recently from d0765cb to b544e46 Compare October 30, 2024 20:58
@omarcopires omarcopires marked this pull request as ready for review October 31, 2024 02:32
Copy link
Contributor

@dudantas dudantas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a few suggestions, if you'd like to implement them. It was done this way before, but since you're already working on this part, I believe it wouldn't be too much additional effort.

Copy link

sonarcloud bot commented Nov 13, 2024

@dudantas dudantas merged commit f34cb83 into opentibiabr:main Nov 13, 2024
18 checks passed
@omarcopires omarcopires deleted the fix-balloons branch November 13, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: PRs Done
Development

Successfully merging this pull request may close these issues.

Years Balloon onUse
2 participants