feat: improve #2863
Draft
feat: improve #2863
+9,845
−8,430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for C/C++3092 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2024.1.9
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
beats-dh
force-pushed
the
beats-fixs
branch
3 times, most recently
from
b954f4f
to
4d0a313
Compare
mehah
reviewed
Sep 7, 2024
src/game/scheduling/dispatcher.cpp
Outdated
| @@ -135,7 +135,7 @@ void Dispatcher::executeScheduledEvents() { | |||
|
|
|||
| if (task->execute() && task->isCycle()) { | |||
| task->updateTime(); | |||
| threadScheduledTasks.emplace_back(task); | |||
| threadScheduledTasks.emplace(task); | |||
mehah
reviewed
Sep 7, 2024
src/game/scheduling/dispatcher.cpp
Outdated
| if (!thread->tasks[serial].empty()) { | ||
| m_tasks[serial].insert(m_tasks[serial].end(), make_move_iterator(thread->tasks[serial].begin()), make_move_iterator(thread->tasks[serial].end())); | ||
| thread->tasks[serial].clear(); | ||
| { |
mehah
requested changes
Sep 7, 2024
src/game/scheduling/dispatcher.hpp
Outdated
| @@ -207,12 +207,11 @@ class Dispatcher { | |||
| } | |||
|
|
|||
| std::array<std::vector<Task>, static_cast<uint8_t>(TaskGroup::Last)> tasks; | |||
| std::vector<std::shared_ptr<Task>> scheduledTasks; | |||
| phmap::parallel_flat_hash_set_m<std::shared_ptr<Task>> scheduledTasks; | |||
beats-dh
force-pushed
the
beats-fixs
branch
2 times, most recently
from
ef5cdf0
to
d3718ac
Compare
jhogberg
reviewed
Sep 12, 2024
jhogberg
reviewed
Sep 12, 2024
jhogberg
reviewed
Sep 12, 2024
jhogberg
reviewed
Sep 12, 2024
|
@jhogberg |
jhogberg
reviewed
Sep 13, 2024
src/utils/lockfree.hpp
Outdated
| } | ||
| return static_cast<T*>(p); | ||
| return static_cast<T*>(::operator new(n * sizeof(T), static_cast<std::align_val_t>(alignof(T)))); |
| @@ -8,114 +8,62 @@ | |||
| */ | |||
|
|
|||
| #pragma once | |||
| #include <atomic_queue/atomic_queue.h> | |||
There was a problem hiding this comment.
Do we need this? It introduces another layer of complexity that I have a hard time seeing a need for, given how this is currently used.
The per-thread caches are a great idea on their own even without this layer. Is there a reason for the buffers to be recycled across threads?
beats-dh
force-pushed
the
beats-fixs
branch
from
fe4113d
to
03dca05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.