fix: forge correct slots

[dudantas]

Description

Resolves #2718

Type of change

• Bug fix (non-breaking change which fixes an issue)

Checklist

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I checked the PR checks reports
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings

[github-actions]

Qodana for C/C++

9 new problems were found

Inspection name	Severity	Problems
misra-cpp2008-4-5-2	🔶 Warning	4
misra-cpp2008-5-0-6	🔶 Warning	3
function-cognitive-complexity	🔶 Warning	1
signed-bitwise	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.9
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions

[Maah8bt]

convergence bugs items, if you have 2 tier 2 armor items it won't appear below, and if you have armor and a helmet it doesn't work either.

[phacUFPE]

Tested and working as expected.

[github-actions]

Qodana for C/C++

1019 new problems were found

Inspection name	Severity	Problems
misra-cpp2008-5-0-11	🔶 Warning	896
err33-c	🔶 Warning	37
static-accessed-through-instance	🔶 Warning	16
misra-cpp2008-5-0-5	🔶 Warning	13
misra-cpp2008-5-2-12	🔶 Warning	5
function-cognitive-complexity	🔶 Warning	5
misra-cpp2008-4-5-2	🔶 Warning	5
narrowing-conversions	🔶 Warning	3
unnecessary-value-param	🔶 Warning	3
misra-cpp2008-0-1-7	🔶 Warning	3
implicit-bool-conversion	🔶 Warning	3
use-starts-ends-with	🔶 Warning	3
magic-numbers	🔶 Warning	3
misra-cpp2008-5-3-1	🔶 Warning	2
misra-cpp2008-5-0-13	🔶 Warning	2
misra-cpp2008-5-0-6	🔶 Warning	2
unnecessary-copy-initialization	🔶 Warning	2
for-range-copy	🔶 Warning	2
id-dependent-backward-branch	🔶 Warning	2
duplicate-include	🔶 Warning	2
simplify-boolean-expr	🔶 Warning	2
misra-cpp2008-6-4-5	🔶 Warning	1
no-automatic-move	🔶 Warning	1
unroll-loops	🔶 Warning	1
too-small-loop-variable	🔶 Warning	1
convert-member-functions-to-static	🔶 Warning	1
pass-by-value	🔶 Warning	1
inconsistent-declaration-parameter-name	🔶 Warning	1
redundant-casting	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

• Register at Qodana Cloud and configure the action
• Use GitHub Code Scanning with Qodana
• Host Qodana report at GitHub Pages
• Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2024.1.11
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

• Or via our issue tracker: https://jb.gg/qodana-issue
• Or share your feedback: https://jb.gg/qodana-discussions