Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reload and potions issues #2286

Closed
wants to merge 0 commits into from
Closed

fix: reload and potions issues #2286

wants to merge 0 commits into from

Conversation

Mirkaanks
Copy link
Contributor

@Mirkaanks Mirkaanks commented Feb 21, 2024

Corrige a função reload
Corrige Typos e Logica no código.

Remove a função inexata Talkactions() que já esta sendo carregada em /core/scripts.

#2213 e #2240.

Agora caso ocorra falha/sucesso no reload de alguma pasta ele reportara no console.
image

Antes ao usar uma potion com a BP cheia, reportava um errro e não gerava a potion vazia.

potions.lua:callback
Function: ContainerFunctions::luaContainerAddItem
Error Description: Cannot add item to container, error code: 'You cannot put more objects in this container.'
Stack Trace:
Cannot add item to container, error code: 'You cannot put more objects in this container.'
stack traceback:
[C]: in function 'addItem'

Agora caso não haja espaço cairá no chão.

De forma adicional Potions utilizadas na store inbox não criarão potions vazias na mesma.
image

@Mirkaanks Mirkaanks changed the title Fix Reload Fuctions and Logical Fix Reload Fuctions and Potions Issue. Feb 21, 2024
@Mirkaanks Mirkaanks changed the title Fix Reload Fuctions and Potions Issue. Fix: Reload and Potions Issues. Feb 21, 2024
@dudantas
Copy link
Contributor

dudantas commented Feb 21, 2024

Muito bom!

Só tem um problema, você fez algumas indentações no arquivo que diferem do clang-format, precisa liberar o check no seu fork para rodar, se não ele vai continuar quebrado e o pr fica bloqueado. Coloquei draft até resolver isto.
image

@dudantas dudantas changed the title Fix: Reload and Potions Issues. fix: reload and potions issues Feb 21, 2024
@dudantas dudantas marked this pull request as draft February 21, 2024 12:21
@dudantas dudantas marked this pull request as ready for review February 21, 2024 19:00
@Mirkaanks Mirkaanks closed this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants