fix: debug build from solution and improve NetworkMessage::add functi…

…on (#2926)

This fixes the issue in the debug build for solution (pch was configured
incorrectly)
It also fixes a crash that occurred in the debug build with asan.

src/server/network/message/networkmessage.hpp

@@ -50,8 +50,7 @@ class NetworkMessage {
 		std::array<unsigned char, sizeof(T)> tempBuffer;
 		// Copy data from the buffer to the temporary array
 		std::span<const unsigned char> sourceSpan(buffer.data() + info.position, sizeof(T));
-		auto it = std::ranges::copy(sourceSpan, tempBuffer.begin());
-		g_logger().trace("First value copied from sourceSpan: {}, second value copied from sourceSpan: {}", *it.in, *it.out);
+		std::ranges::copy(sourceSpan, tempBuffer.begin());
 		// Update the read position in the buffer
 		info.position += sizeof(T);
 		// Convert the byte array to type T using std::bit_cast and return the result
@@ -69,22 +68,35 @@ class NetworkMessage {
 
 	template <typename T>
 	void add(T value, std::source_location location = std::source_location::current()) {
+		static_assert(!std::is_same_v<T, double>, "Error: get<double>() is not allowed. Use addDouble() instead.");
+		static_assert(std::is_trivially_copyable_v<T>, "Type T must be trivially copyable");
+
 		if (!canAdd(sizeof(T))) {
-			g_logger().error("Cannot add value of size {}, buffer overflow", sizeof(T));
+			g_logger().error("Cannot add value of size '{}', buffer size: '{}' overflow. Called at line '{}:{}' in '{}'", sizeof(T), buffer.size(), location.line(), location.column(), location.function_name());
 			return;
 		}
 
-		g_logger().trace("[{}] called line '{}:{}' in '{}'", __FUNCTION__, location.line(), location.column(), location.function_name());
+		if (info.position + sizeof(T) > buffer.size()) {
+			g_logger().error("Buffer overflow detected, current position: '{}', value size: '{}', buffer size: '{}'. Called at line '{}:{}' in '{}'", info.position, sizeof(T), buffer.size(), location.line(), location.column(), location.function_name());
+			return;
+		}
 
-		// Ensure that T is trivially copyable
-		static_assert(std::is_trivially_copyable_v<T>, "Type T must be trivially copyable");
 		// Convert the value to an array of unsigned char using std::bit_cast
 		auto byteArray = std::bit_cast<std::array<unsigned char, sizeof(T)>>(value);
+
 		// Create a span from the byte array
 		std::span<const unsigned char> byteSpan(byteArray);
-		// Copy the bytes into the buffer
-		auto it = std::ranges::copy(byteSpan.begin(), byteSpan.end(), buffer.begin() + info.position);
-		g_logger().trace("First value copied from sourceSpan: {}, second value copied from sourceSpan: {}", *it.in, *it.out);
+
+		// Check if the size of byteSpan can fit into the buffer
+		if (byteSpan.size() > (buffer.size() - info.position)) {
+			g_logger().error("Buffer overflow during span copy. Source span size: {}, buffer available space: {}", byteSpan.size(), buffer.size() - info.position);
+			return;
+		}
+
+		g_logger().trace("[{}] called at line '{}:{}' in '{}'", __FUNCTION__, location.line(), location.column(), location.function_name());
+
+		std::ranges::copy(byteSpan, buffer.begin() + info.position);
+
 		info.position += sizeof(T);
 		info.length += sizeof(T);
 	}

vcproj/canary.vcxproj

@@ -509,7 +509,7 @@
       <WarningLevel>Level1</WarningLevel>
       <MultiProcessorCompilation>true</MultiProcessorCompilation>
       <LanguageStandard>stdcpp20</LanguageStandard>
-      <PrecompiledHeaderFile />
+      <PrecompiledHeaderFile>pch.hpp</PrecompiledHeaderFile>
       <SupportJustMyCode>true</SupportJustMyCode>
       <DebugInformationFormat>ProgramDatabase</DebugInformationFormat>
       <WholeProgramOptimization>true</WholeProgramOptimization>
@@ -518,6 +518,7 @@
       <LanguageStandard_C>Default</LanguageStandard_C>
       <AdditionalOptions>/Zc:__cplusplus /fsanitize=address %(AdditionalOptions)</AdditionalOptions>
       <PreprocessorDefinitions>_DISABLE_VECTOR_ANNOTATION;_DISABLE_STRING_ANNOTATION;%(PreprocessorDefinitions)</PreprocessorDefinitions>
+      <PrecompiledHeader>Use</PrecompiledHeader>
     </ClCompile>
     <Link>
       <SubSystem>Console</SubSystem>