Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util/netif-mgmt: only include missing strlcpy header if actually missing #497

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

Stefan-Schmidt
Copy link
Contributor

In commit 4e2ef14 this header was
added unconditionally. For my system (Yocto with musl) this results in
strlcpy being redefined to __missing_strlcpy in all cases. No matter if
strlcpy is available or not.

Given it is available and the nl.m4 macros detects this, the libstrlcpy.la
helper is not build which results in:

netif-mgmt.c:386: more undefined references to `___missing_strlcpy' follow

Signed-off-by: Stefan Schmidt stefan.schmidt@huawei.com

In commit 4e2ef14 this header was
added unconditionally. For my system (Yocto with musl) this results in
strlcpy being redefined to __missing_strlcpy in all cases. No matter if
strlcpy is available or not.

Given it is available and the nl.m4 macros detects this, the libstrlcpy.la
helper is not build which results in:

netif-mgmt.c:386: more undefined references to `___missing_strlcpy' follow

Signed-off-by: Stefan Schmidt <stefan.schmidt@huawei.com>
@google-cla
Copy link

google-cla bot commented May 21, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Stefan-Schmidt
Copy link
Contributor Author

@googlebot I signed it!

@Stefan-Schmidt
Copy link
Contributor Author

Ping. First contribution here. CLA signed and Github checks are passing. Anything else I need to be aware of? Or just some patience. :-)

@jwhui jwhui requested a review from abtink May 27, 2021 18:00
@abtink abtink merged commit bf45115 into openthread:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants