Skip to content

[ot-docs] Windows 10 support clarifications and add TI Hardware Codelab button - #222

Merged
jwhui merged 6 commits into
openthread:mainfrom
jrhodie:main
Oct 9, 2026
Merged

jwhui merged 6 commits into
openthread:mainfrom
jrhodie:main

Conversation

@jrhodie

@jrhodie jrhodie commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Pyspinel installation guide to clarify Windows support limitations and add installation instructions for Windows users. The reviewer provided feedback to relocate the Windows installation note from under the License header to the correct installation section, and suggested removing the redundant ipaddress package from the pip installation command since it is a built-in Python 3 module.

Comment thread site/en/guides/pyspinel/install-pyspinel.md Outdated
@jrhodie
jrhodie requested review from Vyrastas and jwhui October 5, 2026 23:23
@jrhodie
jrhodie requested a review from Vyrastas October 6, 2026 00:47
@jrhodie jrhodie changed the title [ot-docs] Windows 10 support clarifications [ot-docs] Windows 10 support clarifications and and add TI Hardware Codelab button Oct 6, 2026
@jrhodie jrhodie changed the title [ot-docs] Windows 10 support clarifications and and add TI Hardware Codelab button [ot-docs] Windows 10 support clarifications and add TI Hardware Codelab button Oct 6, 2026
@jrhodie

jrhodie commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

added TI Hardware Codelab button to the .../guides/index.md file after your initial approval, Jeff

@jwhui jwhui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider also updating the note in site/en/guides/pyspinel/index.md (lines 16–17) so it aligns with the Windows 10 extcap support described here.

Comment thread site/en/guides/pyspinel/install-pyspinel.md Outdated
Comment thread site/en/guides/pyspinel/requirements.md Outdated
@jrhodie
jrhodie requested a review from jwhui October 6, 2026 17:29

@jwhui jwhui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since there are now five vendor hardware codelabs listed under ### Hardware Codelabs in site/en/guides/index.md, consider generalizing line 42 from Flash OpenThread on Nordic nRF52840 or Silicon Labs EFR32 development boards to Flash OpenThread on development boards.

Comment thread site/en/guides/pyspinel/index.md Outdated
Comment thread site/en/guides/pyspinel/requirements.md Outdated
@jrhodie
jrhodie requested a review from jwhui October 6, 2026 20:36
Comment thread site/en/guides/index.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jrhodie Can you address the comment @jwhui had about this line?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@jrhodie
jrhodie requested a review from Vyrastas October 8, 2026 22:23

@jwhui jwhui left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍🏼

@jwhui
jwhui merged commit f0deaf4 into openthread:main Oct 9, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants