Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[agent] add mainloop poll timeout config #2555

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bukepo
Copy link
Member

@bukepo bukepo commented Oct 22, 2024

No description provided.

Copy link
Contributor

@Irving-cl Irving-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.50%. Comparing base (2b41187) to head (5ce68df).
Report is 833 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2555       +/-   ##
===========================================
- Coverage   55.77%   45.50%   -10.28%     
===========================================
  Files          87      102       +15     
  Lines        6890    12202     +5312     
  Branches        0      893      +893     
===========================================
+ Hits         3843     5552     +1709     
- Misses       3047     6348     +3301     
- Partials        0      302      +302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/agent/application.cpp Outdated Show resolved Hide resolved
src/agent/application.cpp Outdated Show resolved Hide resolved
src/agent/application.cpp Outdated Show resolved Hide resolved
@bukepo bukepo requested a review from superwhd October 22, 2024 03:49
Copy link
Contributor

@superwhd superwhd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants