Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thread-host] add set country code api #2550

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

Irving-cl
Copy link
Contributor

This PR adds the SetCountryCode method to ThreadHost.

The PR implements this method for RcpHost. The implementation for NCP will be added later.

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 45.47%. Comparing base (2b41187) to head (a1ae0d2).
Report is 835 commits behind head on main.

Files with missing lines Patch % Lines
src/ncp/rcp_host.cpp 0.00% 10 Missing ⚠️
src/ncp/ncp_host.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2550       +/-   ##
===========================================
- Coverage   55.77%   45.47%   -10.31%     
===========================================
  Files          87      102       +15     
  Lines        6890    12209     +5319     
  Branches        0      894      +894     
===========================================
+ Hits         3843     5552     +1709     
- Misses       3047     6355     +3308     
- Partials        0      302      +302     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@zhanglongxia zhanglongxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/ncp/rcp_host.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@sunytt sunytt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Irving-cl Irving-cl requested a review from jwhui October 21, 2024 06:08
src/ncp/thread_host.hpp Outdated Show resolved Hide resolved
@jwhui jwhui changed the title [thread host] add set country code api [thread-host] add set country code api Oct 22, 2024
@jwhui jwhui merged commit dc6b912 into openthread:main Oct 22, 2024
32 checks passed
@Irving-cl Irving-cl deleted the thread_host_set_country_code branch October 24, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants