Draft
Conversation
gztensor
added
the
skip-cargo-audit
… in the share pool
…p_coldkey and swap_hotkey
shamil-gadelshin
requested changes
Jan 26, 2026
Collaborator
shamil-gadelshin
left a comment
shamil-gadelshin
left a comment
There was a problem hiding this comment.
Great work!
A couple of comments:
- What is the reason we copy zstd-* libs in our repo? I would move zstd-libs into separate crates and reference them like our
blspatch. - We need to merge #2251 to integrate "swap coldkey changes" first
- Consider hiding Alpha map access behind some "temporary interface". It'll allow implementing Alphav2 logic easily. We would remove the interface after the migration period.
- I don't see effects on the root claim (it should work as expected)
|
|
||
| // Same thing as populate_root_coldkey_staking_maps, but for AlphaV2 | ||
| pub fn populate_root_coldkey_staking_maps_v2() { | ||
| // Get starting key for the batch. Get the first key if we restart the process. |
Collaborator
There was a problem hiding this comment.
Why do we need this?
Contributor
Author
There was a problem hiding this comment.
In case if slow migration doesn't finish by the time this PR is on mainnet, this function may get used. Leaving in for now, but will mark it with a "TODO" to remove later.
Contributor
Yes, I ended up doing this because the upstream zstd crate is broken with respect to no_std when using the particular target we use. I agree we should fork it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allow paying transaction fees in alpha when no tao balance is available.
See issue #2336 for details.
Related Issue(s)
Type of Change
Breaking Change
The
AlphaandTotalHotkeySharesmaps will be deprecated in favor of high precisionAlphaV2andTotalHotkeySharesV2.Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctly