-
Notifications
You must be signed in to change notification settings - Fork 229
add PureKilled
event to proxy pallet
#1772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one change to be done
There should be more tests so that if in the future ANY type is accidentally hardcoded as an event type being emitted, the unit tests will find the regression, where the event does not properly report the proxy type (or maybe some other parameter) |
will need to merge in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whats up with the run_node.sh
scripts? Those should be removed.
on it sorry |
Description
This PR is to add
PureKilled
event topallet-proxy
.Type of Change
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctly