Add logo_url to subnet identities#1750
Conversation
| } | ||
|
|
||
| #[precompile::public( | ||
| "registerNetwork(bytes32,string,string,string,string,string,string,string,string)" |
There was a problem hiding this comment.
I've left the method name the same, just added a new parameter. Only the internal function name has changed.
There was a problem hiding this comment.
We also need the matching change in precompiles/src/solidity/subnet.sol and subnet.abi. Now they are missing the register_network_with_identity_v2 method.
There was a problem hiding this comment.
I've added these now
| .zip(&subnet_list) | ||
| .find(|(_, subnet)| *subnet == &NetUid::from(*netuid)) | ||
| { | ||
| *w = I64F64::saturating_from_num(*weight_ij); |
There was a problem hiding this comment.
This was raising a linting error, then I realised the method was redundant, so I deleted it. Nothing to do with the logo_url work, I can revert if needed.
| } | ||
|
|
||
| #[precompile::public( | ||
| "registerNetwork(bytes32,string,string,string,string,string,string,string,string)" |
There was a problem hiding this comment.
We also need the matching change in precompiles/src/solidity/subnet.sol and subnet.abi. Now they are missing the register_network_with_identity_v2 method.
|
lovely, re-running CI |
sam0x17
added
the
skip-cargo-audit
|
ok looks good! |
3 participants
Description
Fixes #1368, but I've ignored the bit about the twitter handle as the old chain identity I was comparing to is no longer in use on Bittensor.
Related Issue(s)
Type of Change
New v3 struct for SubnetIdentity, with migration plus new precompile method.
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.