Skip to content

Introduce SameSubnetId error for move and swap stake extrinsics. #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025

Conversation

shamil-gadelshin
Copy link
Collaborator

Description

This PR introduces SameSubnetId error for all extrinsics related to moving stake (move, stake, and their versions with limits). The change was introduced in the shared inner method validate_stake_transition. The new code prevents the stake from moving for the same origin and destination subnets for the same coldkey and hotkey. The PR also changes tests and related benchmarks.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

The PR introduces a new error for the same subnets, coldkeys, and hotkeys.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shamil-gadelshin shamil-gadelshin added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label May 2, 2025
@shamil-gadelshin shamil-gadelshin changed the base branch from add-stake-limit-fix to devnet-ready May 6, 2025 08:46
@shamil-gadelshin shamil-gadelshin marked this pull request as ready for review May 6, 2025 08:47
sam0x17
sam0x17 previously approved these changes May 6, 2025
@sam0x17 sam0x17 merged commit 0b0dfd1 into devnet-ready May 7, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants