Skip to content

Remove obsolete storage items. #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 25, 2025
Merged

Conversation

shamil-gadelshin
Copy link
Collaborator

Description

Remove obsolete storage items from the blockchain state:

  • LastHotkeyColdkeyEmissionOnNetuid
  • SubnetAlphaEmissionSell
  • NetworkMinAllowedUids
  • NeuronsToPruneAtNextEpoch
  • DynamicBlock (migrate_rao)
  • TotalStakeAtDynamic (migrate_rao, do_register_network)
  • SubnetName (get_name_for_subnet)

These storage items were removed; related migrations and migration tests were added as well. Only two items have entries: DynamicBlock(value) and TotalStakeAtDynamic (96 items = 4KB). All storage types (value, map, double map) are treated as raw DB items using a single template method.

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

All dependent applications must be reworked.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shamil-gadelshin shamil-gadelshin added breaking-change This PR introduces a noteworthy breaking change skip-cargo-audit This PR fails cargo audit but needs to be merged anyway labels Apr 25, 2025
Copy link
Contributor

@opentensor/cerebrum / @opentensor/gyrus / @opentensor/cortex breaking change detected! Please prepare accordingly!

@sam0x17 sam0x17 merged commit c9d0fd7 into devnet-ready Apr 25, 2025
32 checks passed
This was referenced Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change This PR introduces a noteworthy breaking change skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants