Skip to content

Add missing benchmarks. #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

Conversation

shamil-gadelshin
Copy link
Collaborator

Description

This PR adds missing benchmarks for staking extrinsics:

  • benchmark_add_stake_limit
  • benchmark_remove_stake_limit
  • benchmark_add_stake_limit_aggregate
  • benchmark_remove_stake_limit_aggregate

This is a subtask for #1525

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe): add benchmarks for existing code

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@shamil-gadelshin shamil-gadelshin added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Apr 17, 2025
@shamil-gadelshin shamil-gadelshin marked this pull request as ready for review April 17, 2025 16:37
@sam0x17 sam0x17 requested a review from a team April 17, 2025 16:53
@sam0x17 sam0x17 merged commit ca1c65b into aggregate-stakes Apr 17, 2025
16 of 18 checks passed
This was referenced Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants