Feat/subtoken enable #1512
Merged
Feat/subtoken enable #1512
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
run-bittensor-e2e-tests
open-junius
added
the
skip-cargo-audit
open-junius
requested review from
camfairchild,
gztensor,
sam0x17 and
ales-otf
and removed request for
camfairchild
l0r1s
reviewed
Apr 14, 2025
evm-tests/src/subtensor.ts
Outdated
| } | ||
|
|
||
| export async function setSubtokenEnable(api: TypedApi<typeof devnet>, netuid: number, subtokenEnable: boolean) { | ||
| const singer = getAliceSigner() |
There was a problem hiding this comment.
Suggested change
| const singer = getAliceSigner() | |
| const signer = getAliceSigner() |
l0r1s
reviewed
Apr 14, 2025
evm-tests/src/subtensor.ts
Outdated
| } | ||
| await new Promise((resolve) => setTimeout(resolve, 2000)); | ||
|
|
||
| const singer = getSignerFromKeypair(keypair) |
There was a problem hiding this comment.
Suggested change
| const singer = getSignerFromKeypair(keypair) | |
| const signer = getSignerFromKeypair(keypair) |
There was a problem hiding this comment.
will fix it, thanks!
|
Only small nits, can ignore if you want 👍 |
sam0x17
approved these changes
Apr 15, 2025
This was referenced Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Type of Change
Breaking Change
If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.
Checklist
cargo fmtandcargo clippyto ensure my code is formatted and linted correctlyScreenshots (if applicable)
Please include any relevant screenshots or GIFs that demonstrate the changes made.
Additional Notes
Please provide any additional information or context that may be helpful for reviewers.