Skip to content

Change update_moving_price() function #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2025
Merged

Conversation

shamil-gadelshin
Copy link
Collaborator

Description

We're changing update_moving_price() function to use FirstEmissionBlockNumber parameter instead of NetworkRegisteredAt. We need this change to take another block from the subnet lifecycle to calculate the moving price. Initially, we used the registration block, but the block of the invocation of start_call() function is more valid. start_call() sets FirstEmissionBlockNumber storage map and emits the related event.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Additional Notes

The new code expects start_call() to be called before update_moving_price(); otherwise, the first_emissions_block defaults to zero. The block affecting the calculation is FirstEmissionBlockNumber minus one block because start_block sets FirstEmissionBlockNumber to the next block instead of the current one.

- change the function to use FirstEmissionBlockNumber parameter instead of NetworkRegisteredAt.
@github-actions github-actions bot added the run-bittensor-e2e-tests Runs Bittensor SDK and BTCLI tests label Apr 2, 2025
@sam0x17 sam0x17 added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label Apr 2, 2025
@sam0x17 sam0x17 merged commit 1c61c73 into devnet-ready Apr 2, 2025
83 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-bittensor-e2e-tests Runs Bittensor SDK and BTCLI tests skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants