Change update_moving_price()
function
#1496
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're changing
update_moving_price()
function to useFirstEmissionBlockNumber
parameter instead ofNetworkRegisteredAt
. We need this change to take another block from the subnet lifecycle to calculate the moving price. Initially, we used the registration block, but the block of the invocation ofstart_call()
function is more valid.start_call()
setsFirstEmissionBlockNumber
storage map and emits the related event.Type of Change
Checklist
cargo fmt
andcargo clippy
to ensure my code is formatted and linted correctlyAdditional Notes
The new code expects
start_call()
to be called beforeupdate_moving_price()
; otherwise, thefirst_emissions_block
defaults to zero. The block affecting the calculation isFirstEmissionBlockNumber
minus one block becausestart_block
sets FirstEmissionBlockNumber to the next block instead of the current one.