Skip to content

Account ID improvements #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 12, 2025
Merged

Account ID improvements #25

merged 6 commits into from
May 12, 2025

Conversation

thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented May 12, 2025 •
edited
Loading

  1. Adds default arg legacy_account_id to decode and decode_list, so as not to break backwards compatibility
  2. Only dumps Account ID strings out of tuples, e.g. '5F27Eqz2PhyMtGMEce898x31DokNqRVxkm5AhDDe6rDGNvoY' vs ('5F27Eqz2PhyMtGMEce898x31DokNqRVxkm5AhDDe6rDGNvoY',) instead of all singleton tuples decoded

@thewhaleking thewhaleking changed the title [WIP] Account ID improvements Account ID improvements May 12, 2025
@thewhaleking thewhaleking marked this pull request as ready for review May 12, 2025 20:29
@thewhaleking thewhaleking requested review from camfairchild and a team May 12, 2025 20:29
@thewhaleking thewhaleking merged commit 3028958 into main May 12, 2025
12 checks passed
@thewhaleking thewhaleking deleted the feat/thewhaleking/account-id-improvements branch May 12, 2025 20:34
@thewhaleking thewhaleking linked an issue May 12, 2025 that may be closed by this pull request
Add Legacy accountid decode option #24
Closed
@thewhaleking thewhaleking mentioned this pull request Jun 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camfairchild camfairchild camfairchild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Legacy accountid decode option
2 participants
@thewhaleking @camfairchild