Skip to content

Fixes broken e2e tests#3020

Merged
basfroman merged 14 commits intostagingfrom
fix/thewhaleking/broken-e2e-tests
Aug 20, 2025
Merged

Fixes broken e2e tests#3020
basfroman merged 14 commits intostagingfrom
fix/thewhaleking/broken-e2e-tests

Conversation

@thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Aug 15, 2025

see: #3019

Fixes test_subtensor_extrinsics by correctly calculating the extrinsic fee.

Comments out the broken part of test_batch_operations with an explanation as to why the calculation is not possible for that test.

Adds calculation of the fees within the unstaking extrinsics (sync and async), as well as outputting this fee in the logger.

Adds TODO questions for the unstake method for both Subtensor and AsyncSubtensor enquiring as to why the netuid arg is Optional[int] rather than int.

Should unblock e2e failures.

@thewhaleking thewhaleking requested a review from a team August 15, 2025 10:46
@thewhaleking thewhaleking linked an issue Aug 15, 2025 that may be closed by this pull request
@thewhaleking
Copy link
Contributor Author

Still sometimes failing flaky tests (see #3015), but that's not the point of this PR.

@thewhaleking thewhaleking added bug Something isn't working testing and removed bug Something isn't working testing labels Aug 15, 2025
Copy link
Collaborator

@basfroman basfroman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but let’s move all the fee calculation logic into utility modules within the extrics sub-packages, so it can be reused from a single place and follows the DRY principle.

@basfroman basfroman self-requested a review August 20, 2025 00:18
basfroman
basfroman previously approved these changes Aug 20, 2025
camfairchild
camfairchild previously approved these changes Aug 20, 2025
@basfroman
Copy link
Collaborator

basfroman commented Aug 20, 2025

Still flaky tests:

  • tests/e2e_tests/test_liquidity.py - fixed
  • tests/e2e_tests/test_staking.py - subtensor related issue

@basfroman basfroman dismissed stale reviews from camfairchild and themself via 101d716 August 20, 2025 01:13
@camfairchild camfairchild self-requested a review August 20, 2025 20:30
@basfroman basfroman merged commit b855e8e into staging Aug 20, 2025
350 of 351 checks passed
@basfroman basfroman deleted the fix/thewhaleking/broken-e2e-tests branch August 20, 2025 21:25
This was referenced Aug 28, 2025
@basfroman basfroman mentioned this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing E2E tests

3 participants