Merged
Conversation
Closed
This was referenced Aug 15, 2025
Closed
Contributor
Author
|
Still sometimes failing flaky tests (see #3015), but that's not the point of this PR. |
This was referenced Aug 15, 2025
basfroman
requested changes
Aug 18, 2025
Collaborator
basfroman
left a comment
There was a problem hiding this comment.
Looks good, but let’s move all the fee calculation logic into utility modules within the extrics sub-packages, so it can be reused from a single place and follows the DRY principle.
added 6 commits
August 19, 2025 15:54
basfroman
previously approved these changes
Aug 20, 2025
camfairchild
previously approved these changes
Aug 20, 2025
Collaborator
|
Still flaky tests:
|
camfairchild
approved these changes
Aug 20, 2025
This was referenced Aug 28, 2025
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: #3019
Fixes
test_subtensor_extrinsicsby correctly calculating the extrinsic fee.Comments out the broken part of
test_batch_operationswith an explanation as to why the calculation is not possible for that test.Adds calculation of the fees within the unstaking extrinsics (sync and async), as well as outputting this fee in the logger.
Adds TODO questions for the
unstakemethod for bothSubtensorandAsyncSubtensorenquiring as to why the netuid arg isOptional[int]rather thanint.Should unblock e2e failures.