New logic to get price for DynamicInfo#2952
Merged
Conversation
thewhaleking
reviewed
Jul 8, 2025
| k=tao_in.rao * alpha_in.rao, | ||
| is_dynamic=is_dynamic, | ||
| price=price, | ||
| price=decoded.get("price", None), |
Contributor
There was a problem hiding this comment.
Price should be a Balance type
Collaborator
Author
There was a problem hiding this comment.
The balance is Optional. I don't want to create another convention that if the price = 0 then it is not transferred or something else. There is no price, so it is not passed.
The user may want to use the subnet data without a price in his/her script independently.
Collaborator
Author
There was a problem hiding this comment.
But we raise the error in case price isn't None or Balance
added 2 commits
July 8, 2025 16:10
ibraheem-abe
previously approved these changes
Jul 8, 2025
ibraheem-abe
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Subtensors have new methods:
get_subnet_priceget_subnet_prices