Skip to content

remove uses of return scale obj #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewhaleking merged 3 commits into from
Nov 26, 2024
Merged

remove uses of return scale obj #2479

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31f78bc
decode_scale's return_scale_obj arg was removed, but its references w…
thewhaleking Nov 26, 2024
3934647
Clean up
thewhaleking Nov 26, 2024
5547717
Merge branch 'staging' into fix/thewhaleking/remove-uses-of-return-sc…
ibraheem-abe Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions bittensor/utils/async_substrate_interface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1613,8 +1613,7 @@ async def _process_response(
q = bytes(query_value)
else:
q = query_value
obj = await self.decode_scale(value_scale_type, q, True)
result = obj
result = await self.decode_scale(value_scale_type, q)
if asyncio.iscoroutinefunction(result_handler):
# For multipart responses as a result of subscriptions.
message, bool_result = await result_handler(response, subscription_id)
Expand Down Expand Up @@ -2346,7 +2345,6 @@ async def get_constant(
return await self.decode_scale(
constant.type,
bytes(constant.constant_value),
return_scale_obj=True,
)
else:
return None
Expand Down Expand Up @@ -2571,7 +2569,6 @@ def concat_hash_len(key_hasher: str) -> int:
item_key_obj = await self.decode_scale(
type_string=f"({', '.join(key_type_string)})",
scale_bytes=bytes.fromhex(item[0][len(prefix) :]),
return_scale_obj=True,
)

# strip key_hashers to use as item key
Expand All @@ -2592,9 +2589,7 @@ def concat_hash_len(key_hasher: str) -> int:
item_bytes = hex_to_bytes(item[1])

item_value = await self.decode_scale(
type_string=value_type,
scale_bytes=item_bytes,
return_scale_obj=True,
type_string=value_type, scale_bytes=item_bytes
)
except Exception as _:
if not ignore_decoding_errors:
Expand Down