Merged
Conversation
…l. Updated AsyncSubstrate to use the updated async websocket client, bumped websockets version req to 14.1.
basfroman
requested changes
Nov 21, 2024
Co-authored-by: Roman <167799377+roman-opentensor@users.noreply.github.com>
Co-authored-by: Roman <167799377+roman-opentensor@users.noreply.github.com>
basfroman
approved these changes
Nov 21, 2024
thewhaleking
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the way Subtensor connects to the websocket server. Previously, the websocket was initialized from within SubstrateInterface. However, this was using the stdlib
websocketpackage. The PyPIwebsocketspackage has significantly better stability, and results in no broken pipes in our testing.Furthermore, because we're bumping the websockets requirement version to 14.1+, we're transitioning the async websockets client in AsyncSubstrate to use this updated client.