add neuron certificate discovery#2267
Merged
thewhaleking merged 11 commits intoopentensor:stagingfrom Nov 21, 2024
Merged
Conversation
b25a198 to
7d89d7e
Compare
97f6805 to
b3d222b
Compare
e47da50 to
dabd316
Compare
thewhaleking
requested changes
Nov 19, 2024
Contributor
thewhaleking
left a comment
There was a problem hiding this comment.
One suggestion, and a couple small nitpicks. Overall LGTM.
Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
Co-authored-by: Benjamin Himes <37844818+thewhaleking@users.noreply.github.com>
a40a279 to
2c0bbfb
Compare
3bed339 to
467bcf9
Compare
467bcf9 to
9368030
Compare
thewhaleking
previously approved these changes
Nov 20, 2024
thewhaleking
approved these changes
Nov 21, 2024
Merged
| "protocol": protocol, | ||
| "placeholder1": placeholder1, | ||
| "placeholder2": placeholder2, | ||
| "certificate": certificate, |
Contributor
There was a problem hiding this comment.
Won't this make neuron_up_to_date always False? Just not sure if that's intended behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Adding, Changing, or Removing a Feature
subtensor migrated to version that handles certificate discovery
Description of the Change
Adds the ability to send neuron certificate and receive other neuron's certificates. This change will enable setting up mutual tls between neurons
serve_axonfunction takes an additional optional parameter certificateif certificate is present the
serve_axon_tlsrpc call will be called on the subtensor and the neuron's certificate will be discoverable through the subtensor. The function will behave the same other than the possible storing of certificate.get_neuron_certificate(netuid, neuron_uid)will fetch from the subtensor a specific neuron's certificate.Alternate Designs
save the certificate as a field in the axon.
This can be implemented either:
serve_axon,get_neuron_infoand other function. However this would break compatibility for multiple rpc calls encoding and would need patching.Possible Drawbacks
none?
Verification Process
TODO
Release Notes
serve_axonfunction and fetched via theget_neuron_certificatefunction