Skip to content

fixes tensors not hashing correctly #1545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CreativeBuilds wants to merge 2 commits into from
Closed

fixes tensors not hashing correctly #1545

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4877634
fixes tensors not hashing correctly
CreativeBuilds Oct 14, 2023
738d253
Merge branch 'staging' into fix-dict
ifrit98 Oct 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bittensor/synapse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,8 +513,7 @@ def body_hash(self) -> str:
hashes = []

# Getting the fields of the instance
instance_fields = self.__dict__

instance_fields = self.dict() # __dict__ converts the Tensor types into strings causing a mismatch in the hash, so we use .dict() instead
Copy link
Contributor

@Eugene-hu Eugene-hu Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @ifrit98 would have better visibility on this change than I do, so we should for his approval before merging.

Copy link
Contributor

@Eugene-hu Eugene-hu Oct 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ifrit98 would this create an issue for the header size? If I am not mistaken, there is a sizing limit on the headers which caused us to create hashes rather than using the full tensor.

for field, value in instance_fields.items():
# If the field is required in the subclass schema, hash and add it.
if field in self.required_hash_fields:
Expand Down