Skip to content

Hash fix #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ifrit98 merged 1 commit into from
Sep 26, 2023
Merged

Hash fix #1519

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions bittensor/axon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,9 +509,12 @@ async def some_endpoint(body_dict: dict = Depends(verify_body_integrity)):
# The function only executes if the body integrity verification is successful.
...
"""
# Extract keys and values that end with '_hash'
hash_headers = {k: v for k, v in request.headers.items() if "_hash_" in k}
hash_headers = {k.split("_")[-1]: v for k, v in hash_headers.items()}
# Properly extract keys and values that have 'hash'
hash_headers = {
"_".join(k.split("_")[k.split("_").index("hash") + 1 :]): v
for k, v in request.headers.items()
if "_hash_" in k
}

# Await and load the request body so we can inspect it
body = await request.body()
Expand All @@ -521,7 +524,13 @@ async def some_endpoint(body_dict: dict = Depends(verify_body_integrity)):
body_dict = json.loads(request_body)
for required_field in list(hash_headers):
# Hash the field in the body to compare against the header hashes
field_hash = bittensor.utils.hash(str(body_dict[required_field]))
body_value = body_dict.get(required_field, None)
if body_value == None:
return JSONResponse(
content={"error": f"Missing required field {required_field}"},
status_code=400,
)
field_hash = bittensor.utils.hash(str(body_value))

# If any hashes fail to match up, return a 400 error as the body is invalid
if field_hash != hash_headers[required_field]:
Expand Down