chore(xtest): Audit and local improvements together#390
chore(xtest): Audit and local improvements together#390dmihalcik-virtru wants to merge 5 commits intoopentdf:mainfrom
Conversation
dmihalcik-virtru
commented
Jan 27, 2026
dmihalcik-virtru
commented
- feat(xtest): add tmux-based local test environment with modular scripts
- feat(xtest): add audit log processing framework and test integration
Summary of ChangesHello @dmihalcik-virtru, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly overhauls the local testing infrastructure for the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new audit logging framework for tests and refactors the local test environment to use a modular, tmux-based shell script system. The changes are extensive and well-structured. The new audit log framework is a great addition for improving test diagnostics, and the shell script refactoring improves maintainability. I've found a critical issue in a path helper function within the new script library and some minor path issues in the updated documentation. Overall, this is a significant improvement to the test infrastructure.
xtest/scripts/lib/core/paths.sh
Outdated
| get_platform_dir() { | ||
| local xtest_dir | ||
| xtest_dir="$(get_xtest_dir)" | ||
| echo "$(cd "$xtest_dir/../../platform" && pwd)" | ||
| } |
There was a problem hiding this comment.
The get_platform_dir function appears to construct an incorrect path. It uses cd "$xtest_dir/../../platform", which resolves to a directory one level above the repository root. Assuming the platform directory is a sibling of the xtest directory within the repository, the correct relative path should be ../platform from the xtest directory.
| get_platform_dir() { | |
| local xtest_dir | |
| xtest_dir="$(get_xtest_dir)" | |
| echo "$(cd "$xtest_dir/../../platform" && pwd)" | |
| } | |
| get_platform_dir() { | |
| local xtest_dir | |
| xtest_dir="$(get_xtest_dir)" | |
| echo "$(cd "$xtest_dir/../platform" && pwd)" | |
| } |
|
|
||
| ## Build, Test, and Development Commands | ||
| ### Structure | ||
| - **Test Directory**: `tests/xtest/` - pytest-based integration tests |
There was a problem hiding this comment.
This documentation contains a few incorrect paths that could confuse users:
- On line 8, the test directory should be
xtest/, nottests/xtest/. - Several example commands (e.g., on lines 347, 361, 362, 714) use paths like
platform/opentdf-dev.yaml. Since test commands are typically run from thextest/directory, the correct relative path to the platform directory would be../platform/.
dmihalcik-virtru
force-pushed
the
chore/the-claudiest-day-tmux
branch
from
7dfa6b5 to
41fc3fe
Compare
- Implement lmgmt Python CLI tool for managing local test environment - Add service abstraction (Platform, KAS, Docker, Provisioner) - Implement health checks and wait utilities - Add structured log aggregation with filtering capabilities - Include comprehensive pytest integration tests - Update CI workflows for audit log collection
- Add comprehensive audit log test coverage for TDF roundtrip, ABAC, and policy tests - Implement clock skew estimation for accurate timestamp comparison - Increase audit log assertion timeout and report late-arriving logs - Add integration tests for audit log collection in CI pipeline - Make audit assertions required by default with override option
- Fix subprocess deadlock in otdfctl by properly handling stdout/stderr - Capture stderr output for better debugging when CLI calls fail - Add env command to lmgmt for outputting pytest environment variables
- Document lmgmt Python CLI as recommended tool for environment management - Add quick reference commands for service management - Update troubleshooting workflow to use lmgmt - Include audit log assertions requirements and disabling procedures
- Add .shfmt configuration for shell script formatting - Update .gitignore for generated files - Update xtest dependencies and manifest schema
dmihalcik-virtru
force-pushed
the
chore/the-claudiest-day-tmux
branch
from
e5921dd to
deb3563
Compare
|
1 participant
