Skip to content

Conversation

@strantalis
Copy link
Member

Removes all NanoTDF-related code and test coverage from xtest. Updates SDK wrapper scripts and CI workflow to run ztdf-only, and refreshes docs accordingly.

@strantalis strantalis requested review from a team as code owners January 6, 2026 18:21
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @strantalis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request systematically removes all code, tests, and configuration related to NanoTDF support from the xtest framework and its associated SDK wrapper scripts. The change streamlines the testing infrastructure to exclusively focus on the Zero Trust Data Format (ZTDF), simplifying the codebase, reducing maintenance overhead, and aligning the testing environment with a singular data format standard. Additionally, testing documentation has been slightly improved.

Highlights

  • NanoTDF Code Removal: The core xtest/nano.py module, which contained the Python implementation for NanoTDF envelope parsing and related structures, has been entirely removed, along with its dedicated test file xtest/test_nano.py.
  • SDK Wrapper Updates: The Go, Java, and JavaScript SDK wrapper scripts (cli.sh files) have been modified to eliminate NanoTDF-specific feature checks and command handling, effectively enforcing Zero Trust Data Format (ZTDF) as the sole supported container type for operations.
  • Test Framework Refinement: The xtest/tdfs.py, xtest/test_policytypes.py, and xtest/test_tdfs.py files have been updated to remove all references to NanoTDF container types and features. This includes adjusting default container types to ZTDF, removing NanoTDF-specific test logic, and streamlining attribute assertion methods.
  • Documentation Update: The TESTING.md file has been updated to provide clearer and more concise instructions for generating local HTML test reports using pytest-html.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/xtest.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@strantalis strantalis changed the title Remove NanoTDF tests and support fix: remove NanoTDF tests and support Jan 6, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes all NanoTDF-related code and tests, which aligns with the stated objective. The changes are comprehensive across the documentation, SDK wrapper scripts, and test suite. However, I've identified a critical bug in xtest/test_tdfs.py where an incorrect indentation change will lead to a NameError and cause test failures under certain conditions.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 6, 2026

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

@github-actions
Copy link

github-actions bot commented Jan 6, 2026

@strantalis strantalis merged commit 150e313 into main Jan 6, 2026
14 checks passed
@strantalis strantalis deleted the strantalis/remove-nanotdf branch January 6, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants