Skip to content

Conversation

@b-long
Copy link

@b-long b-long commented Aug 15, 2025

Small feedback PR, relating to #331

  • Adds tooling to "dev" dependency group, and updates requirements.txt file.
  • Add missing dependency (pyyaml)
  • For now, I'm forcing a zero exit status when ruff and black fail, which can be un-done after those items are fixed.

@b-long b-long requested review from a team as code owners August 15, 2025 16:02
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @b-long, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces pytest as a development dependency, streamlining the testing setup for the project. It updates the dependency management configuration to include pytest in the development environment and makes a minor correction to a shell script related to environment variable checks.

Highlights

  • Development Dependency Addition: pytest has been added to a new dev dependency group within pyproject.toml, specifying version 8.4.1 or newer.
  • Dependency Resolution Update: The requirements.txt file has been updated to reflect the inclusion of pytest and its transitive dependencies, and the uv pip compile command now explicitly compiles the dev dependency group.
  • Shell Script Refinement: A minor correction was made in setup_testrail_env.sh to use the -n operator for checking if an environment variable is non-empty, replacing the less idiomatic ! -z.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces pytest as a development dependency by adding a dev dependency group in pyproject.toml and updating the requirements.txt file accordingly. The change in setup_testrail_env.sh is a minor stylistic improvement. My review includes one suggestion for pyproject.toml to address a redundancy in dependency definition, which will improve the project's maintainability.

Comment on lines 33 to 38
[dependency-groups]
dev = [
"pytest>=8.4.1",
]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

With the addition of the dev dependency group containing pytest, the pytest entry in the xtest optional dependency group on line 29 becomes redundant. This can cause confusion about which group to use for installing test dependencies and may lead to maintenance issues if they get out of sync.

To resolve this, please remove pytest from the xtest group. If the xtest group becomes empty as a result, you could consider removing it entirely for better clarity.

@b-long b-long force-pushed the test-framework-modernization-phase1--bl-feedback2 branch from 848bd43 to 3aa9c64 Compare August 15, 2025 16:08
@b-long b-long force-pushed the test-framework-modernization-phase1--bl-feedback2 branch from 3aa9c64 to 9039e19 Compare August 15, 2025 16:10
@b-long b-long changed the title feat: add pytest as a dev dependency feat: add tooling to dev dependency group Aug 15, 2025
@b-long b-long force-pushed the test-framework-modernization-phase1--bl-feedback2 branch from 2e24ce6 to 5d99eb5 Compare August 15, 2025 16:19
@b-long b-long mentioned this pull request Aug 15, 2025
@sonarqubecloud
Copy link

@pflynn-virtru pflynn-virtru merged commit 83131d6 into test-framework-modernization-phase1 Aug 15, 2025
7 of 9 checks passed
@pflynn-virtru pflynn-virtru deleted the test-framework-modernization-phase1--bl-feedback2 branch August 15, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants