-
Notifications
You must be signed in to change notification settings - Fork 2
feat: add tooling to dev dependency group
#333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add tooling to dev dependency group
#333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @b-long, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces pytest as a development dependency, streamlining the testing setup for the project. It updates the dependency management configuration to include pytest in the development environment and makes a minor correction to a shell script related to environment variable checks.
Highlights
- Development Dependency Addition:
pytesthas been added to a newdevdependency group withinpyproject.toml, specifying version8.4.1or newer. - Dependency Resolution Update: The
requirements.txtfile has been updated to reflect the inclusion ofpytestand its transitive dependencies, and theuv pip compilecommand now explicitly compiles thedevdependency group. - Shell Script Refinement: A minor correction was made in
setup_testrail_env.shto use the-noperator for checking if an environment variable is non-empty, replacing the less idiomatic! -z.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces pytest as a development dependency by adding a dev dependency group in pyproject.toml and updating the requirements.txt file accordingly. The change in setup_testrail_env.sh is a minor stylistic improvement. My review includes one suggestion for pyproject.toml to address a redundancy in dependency definition, which will improve the project's maintainability.
| [dependency-groups] | ||
| dev = [ | ||
| "pytest>=8.4.1", | ||
| ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the addition of the dev dependency group containing pytest, the pytest entry in the xtest optional dependency group on line 29 becomes redundant. This can cause confusion about which group to use for installing test dependencies and may lead to maintenance issues if they get out of sync.
To resolve this, please remove pytest from the xtest group. If the xtest group becomes empty as a result, you could consider removing it entirely for better clarity.
848bd43 to
3aa9c64
Compare
3aa9c64 to
9039e19
Compare
dev dependency group
2e24ce6 to
5d99eb5
Compare
|
83131d6
into
test-framework-modernization-phase1



Small feedback PR, relating to #331
requirements.txtfile.pyyaml)ruffandblackfail, which can be un-done after those items are fixed.