Skip to content

chore(core): Log kas URI on key index requests #2710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmihalcik-virtru merged 1 commit into from
Sep 11, 2025
Merged

chore(core): Log kas URI on key index requests #2710

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions service/kas/key_indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ func convertAlgToEnum(alg string) (policy.Algorithm, error) {
}
}

func (p *KeyIndexer) String() string {
return fmt.Sprintf("PlatformKeyIndexer[%s]", p.kasURI)
}

func (p *KeyIndexer) FindKeyByAlgorithm(ctx context.Context, algorithm string, includeLegacy bool) (trust.KeyDetails, error) {
alg, err := convertAlgToEnum(algorithm)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions service/trust/delegating_key_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func (d *DelegatingKeyService) Name() string {
func (d *DelegatingKeyService) Decrypt(ctx context.Context, keyID KeyIdentifier, ciphertext []byte, ephemeralPublicKey []byte) (ProtectedKey, error) {
keyDetails, err := d.index.FindKeyByID(ctx, keyID)
if err != nil {
return nil, fmt.Errorf("unable to find key by ID '%s': %w", keyID, err)
return nil, fmt.Errorf("unable to find key by ID '%s' within index %s: %w", keyID, d.index, err)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Nov 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the error message in DeriveKey on line 107, consider using in index instead of within index. This makes the error messages uniform, which is helpful for logging and monitoring.

Suggested change
return nil, fmt.Errorf("unable to find key by ID '%s' within index %s: %w", keyID, d.index, err)
return nil, fmt.Errorf("unable to find key by ID '%s' in index %s: %w", keyID, d.index, err)

}

manager, err := d.getKeyManager(keyDetails.System())
Expand All @@ -104,7 +104,7 @@ func (d *DelegatingKeyService) Decrypt(ctx context.Context, keyID KeyIdentifier,
func (d *DelegatingKeyService) DeriveKey(ctx context.Context, keyID KeyIdentifier, ephemeralPublicKeyBytes []byte, curve elliptic.Curve) (ProtectedKey, error) {
keyDetails, err := d.index.FindKeyByID(ctx, keyID)
if err != nil {
return nil, fmt.Errorf("unable to find key by ID '%s': %w", keyID, err)
return nil, fmt.Errorf("unable to find key by ID '%s' in index %s: %w", keyID, d.index, err)
}

manager, err := d.getKeyManager(keyDetails.System())
Expand Down
Loading