fix(sdk): adds connection options to getPlatformConfiguration

[imdominicreed]

Proposed Changes

• connection options should be passed to getPlatformConfiguration.

Checklist

• I have added or updated unit tests
• I have added or updated integration tests (if appropriate)
• I have added or updated documentation

Testing Instructions

[gemini-code-assist]

Hello @imdominicreed, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request. The primary goal of this change, as indicated by the title and description, is to address a fix in the SDK where connection options were not being correctly passed to the getPlatformConfiguration function. This function is responsible for fetching well-known configuration details from the platform. The change involves modifying the internal implementation of this function to ensure that the necessary connection options are included when establishing the gRPC client connection used for this purpose.

Highlights

• Pass Connection Options: The core change ensures that the getPlatformConfiguration function now correctly utilizes the connection options (conn.Options...) when initializing the wellknownconfigurationconnect.NewWellKnownServiceClient. This is crucial for allowing custom connection configurations (like interceptors, timeouts, etc.) to apply to this specific RPC call.

Changelog

• sdk/sdk.go
  • Modified the getPlatformConfiguration function to pass conn.Options... to the wellknownconfigurationconnect.NewWellKnownServiceClient constructor.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

---

Options now flow free,
To config client they go,
Fixing SDK.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

Thank you for submitting this pull request. The change correctly addresses the objective of passing connection options to the getPlatformConfiguration function. This ensures that any configured connect.ClientOptions are applied when fetching the platform configuration.

No specific style guide was provided for this repository. My review is based on standard Go conventions and best practices.

Summary of Findings

• Correctness of passing options: The core code change correctly passes the connection options (conn.Options...) to the NewWellKnownServiceClient constructor, ensuring that client options like interceptors are applied when retrieving the platform configuration.
• Missing tests: The pull request checklist indicates that unit and integration tests have not been added or updated. While the code change is small, adding tests that specifically cover the scenario of passing options to getPlatformConfiguration would improve confidence in the change and help prevent future regressions. This is a medium severity issue for code quality and maintainability.
• Missing documentation updates: The pull request checklist indicates that documentation has not been added or updated. If this change affects how users might interact with the SDK or its configuration options, relevant documentation (e.g., READMEs, Godoc comments) should be updated to reflect the change. This is a medium severity issue for maintainability and usability.

Merge Readiness

The code change itself is correct and implements the intended functionality. However, the pull request checklist indicates that tests and documentation have not been updated. To ensure the quality and maintainability of the SDK, it is recommended that these items be addressed before merging. Therefore, I am requesting changes.

As a code reviewer, I am unable to directly approve this pull request. Please ensure that other reviewers have approved the changes before merging.

[github-actions]

Benchmark results, click to expand

Benchmark Results:

Metric	Value
Approved Decision Requests	5000
Denied Decision Requests	0
Total Time	457.53357ms

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	364.205427ms
Throughput	274.57 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	1m15.304942559s
Average Latency	750.667284ms
Throughput	66.40 requests/second

NANOTDF Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	4943
Failed Requests	57
Concurrent Requests	50
Total Time	1m6.195712392s
Average Latency	658.716149ms
Throughput	74.67 requests/second

Error Summary:

Error Message	Occurrences
ReadNanoTDF error: getNanoRewrapKey: rewrapError: internal: internal error rpc error: code = Internal desc = could not perform access	57 occurrences

Standard Benchmark Metrics Skipped or Failed