fix(core): reduces GetAttributeValuesByFqns calls in getDecisions #1857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Test Plan:
Summary: Test Plan:
imdominicreed
force-pushed
the
fix/list_attrs_get_decisions
branch
from
951893a to
c3cda1b
Compare
dmihalcik-virtru
approved these changes
Jan 15, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 21, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.38](service/v0.4.37...service/v0.4.38) (2025-01-21) ### Features * **core:** adds bulk rewrap to sdk and service ([#1835](#1835)) ([11698ae](11698ae)) ### Bug Fixes * **core:** Autobump service ([#1864](#1864)) ([f9d149b](f9d149b)) * **core:** Autobump service ([#1867](#1867)) ([b8f5101](b8f5101)) * **core:** reduces GetAttributeValuesByFqns calls in getDecisions ([#1857](#1857)) ([5379baf](5379baf)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
GetAttributeValuesByFqnsperResourceAttribute, with bulk rewrap incoming, this can be quite expensive.GetAttributesValuesByFqnsperResourceAttributeget all FQNs in one call by collecting them in theResourceAttribute.Checklist
Testing Instructions
go run ./examples benchmark-decision --insecurePlaintextConn --count 1000locally I got 1.3s vs 80ms, so a very important performance change.