fix(sdk): Fix possible panic for AttributeValueFQN.Prefix()
#1472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jentfoo
changed the title
granter.go panics for AttributeValueFQN.Prefix()AttributeValueFQN.Prefix()
jentfoo
force-pushed
the
jent/granter_panic_fix
branch
2 times, most recently
from
2212de8 to
0981203
Compare
This commit adds additional checks to validate that Attribute Name / Values are not empty or contain a slash. This fixes a panic condition where `NewAttributeValueFQN` would return without error but `Prefix()` would then fail when the prefix is attempted to be parsed by `NewAttributeNameFQN`. This commit includes unit testing, and the fuzz testing that initially discovered this issue. See there for possibly dangerous values. Also included are some minor doc changes, spelling fixes, and some other fuzz testing that was co-located with these changes.
jentfoo
force-pushed
the
jent/granter_panic_fix
branch
from
f271c5f to
ae68427
Compare
Member
jrschumacher
left a comment
jrschumacher
left a comment
There was a problem hiding this comment.
Really awesome to see these contributions!! Thank you.
dmihalcik-virtru
approved these changes
Sep 3, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
This PR includes additional fuzzing and security testing that was not covered in prior PR's (#1472 and #1385). Those PR's include the relevant tests for their fixes, where this provides additional testing that was explored but did not show issues. In addition this PR includes some minor changes that were found while reviewing the code base: * Spelling fixes * Token issue time and expiration based off the same time sample (reduced kernel overheads and also ensures no time skew risks) PR closes #1341
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
🤖 I have created a release *beep* *boop* --- ## [0.3.13](sdk/v0.3.12...sdk/v0.3.13) (2024-10-01) ### Features * **sdk:** Add namesapce grants to key splitting ([#1512](#1512)) ([d9a07f8](d9a07f8)) ### Bug Fixes * **ci:** Fix negative assertion test case false positive ([#1550](#1550)) ([ef40bdb](ef40bdb)) * **core:** Add NanoTDF KID padding removal and update logging level ([#1466](#1466)) ([54de8f4](54de8f4)), closes [#1467](#1467) * **core:** Autobump sdk ([#1513](#1513)) ([03fba13](03fba13)) * **core:** Autobump sdk ([#1577](#1577)) ([df7466b](df7466b)) * **core:** only strip nano kids to the right ([#1475](#1475)) ([ae8d8a2](ae8d8a2)) * **core:** Store attribute specific grants to key cache ([#1507](#1507)) ([8bc0a98](8bc0a98)) * **sdk:** DoS protection through TDF segment sizes ([#1536](#1536)) ([d506734](d506734)) * **sdk:** Fix nanotdf ECC mode bitfield ([#1551](#1551)) ([58a76ad](58a76ad)) * **sdk:** Fix possible panic for `AttributeValueFQN.Prefix()` ([#1472](#1472)) ([144aeda](144aeda)) * **sdk:** Granter offline mode with namespaces and keycache ([#1542](#1542)) ([ecd41f4](ecd41f4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds additional checks to validate that Attribute Name / Values are not empty or contain a slash. This fixes a panic condition where
NewAttributeValueFQNwould return without error butPrefix()would then fail when the prefix is attempted to be parsed byNewAttributeNameFQN.This commit includes unit testing, and the fuzz testing that initially discovered this issue. See there for possibly dangerous values.
An alternative or additional solution that we may want to consider:
If
Prefix()is a common or frequent operation we could proactively invoke theNewAttributeNameFQNfrom withinNewAttributeValueFQN. That way any future validation added toNewAttributeNameFQNwould be proactively checked rather than needingPrefix()to be invoked to be tested.Also included are some minor doc changes, spelling fixes, and some other fuzz testing that was co-located with these changes.
PR closes #1468