feat(core): adds assertions to encrypt subcommand #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedoublev
reviewed
Oct 25, 2024
Contributor
|
Thanks for this @sujankota . Would you please add an e2e test like this one? https://github.com/opentdf/otdfctl/blob/main/e2e/encrypt-decrypt.bats#L60 |
Contributor
|
Guidance from @strantalis is that we will not be merging this yet due to the release freeze. @sujankota what are your thoughts on adding a |
Member
|
Let's do the no-verify in a separate pr so we have cleaner rollbacks |
dmihalcik-virtru
changed the title
Member
|
(--no-verify is a decrypt option, --assertions is an encrypt option) |
Member
|
#419 -- draft to add --no-verify-assertions flag on decrypt |
jakedoublev
reviewed
Nov 6, 2024
jakedoublev
previously approved these changes
Nov 6, 2024
jakedoublev
approved these changes
Nov 6, 2024
jakedoublev
pushed a commit
that referenced
this pull request
Nov 20, 2024
🤖 I have created a release *beep* *boop* --- ## [0.16.0](v0.15.0...v0.16.0) (2024-11-20) ### Features * assertion verification disable ([#419](#419)) ([acf5702](acf5702)) * **core:** add `subject-mappings match` to CLI ([#413](#413)) ([bc56c19](bc56c19)) * **core:** add optional name to kas registry CRUD commands ([#429](#429)) ([f675d86](f675d86)) * **core:** adds assertions to encrypt subcommand ([#408](#408)) ([8f0e906](8f0e906)) * **core:** adds storeFile to save encrypted profiles to disk and updates auth to propagate tlsNoVerify ([#420](#420)) ([f709e01](f709e01)) * refactor encrypt and decrypt + CLI examples ([#418](#418)) ([e681823](e681823)) * support --with-access-token for auth ([#409](#409)) ([856efa4](856efa4)) ### Bug Fixes * **core:** dev selectors employ flattening from platform instead of jq ([#411](#411)) ([57966ff](57966ff)) * **core:** improve readability of TDF methods ([#424](#424)) ([a88d386](a88d386)) * **core:** remove trailing slashes on host/platformEndpoint ([#415](#415)) ([2ffd3c7](2ffd3c7)), closes [#414](#414) * **core:** revert profiles file system storage last commit ([#427](#427)) ([79f2079](79f2079)) * updates sdk to 0.3.19 with GetTdfType fixes ([#425](#425)) ([0a9adfe](0a9adfe)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.