3867 terraform #65
Open
3867 terraform #65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…install and rsync commands
|
It would be nice to have an output for the value |
remo87
reviewed
May 29, 2025
| name = local.clickhouse_disk_name | ||
| description = "Clickhouse data disk" | ||
| type = "pd-ssd" | ||
| zone = "europe-west1-d" |
There was a problem hiding this comment.
Maybe leave this as a variable in case the zone is not available we can configure it. With the default value set to "europe-west1-d"
|
|
||
| // Create a disk volume for Clickhouse data | ||
| resource "google_compute_disk" "clickhouse_data_disk" { | ||
| project = "open-targets-eu-dev" |
There was a problem hiding this comment.
the project could also be a variable with the default value to eu-dev
| clickhouse_steps | ||
| wait | ||
| journalctl -u google-startup-scripts.service > /var/log/google-startup-scripts.log | ||
| gsutil -m cp /var/log/google-startup-scripts.log gs://open-targets-ops/logs/platform-pos/${INSTANCE_LABEL}/pos/google-startup-scripts.log |
There was a problem hiding this comment.
We could add an output to get the log file
jdhayhurst
force-pushed
the
3867-terraform
branch
from
af5e8ba to
146b560
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves opentargets/issues#3867