chore(lodash): [RO-26515] Removes unneeded lodash deps with native replacements #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolchado
commented
Apr 9, 2024
| module.exports = function (Promise) { | ||
| class FixtureCache { | ||
|
|
||
| constructor() { | ||
| this.cache = {}; | ||
|
|
||
| _bindAll(this, ['set', 'get', 'getOrPromise', 'setAsync']); |
There was a problem hiding this comment.
getOrPromise is not called in an async method in the class, so context is not needed
acolchado
commented
Apr 9, 2024
| module.exports = function (Promise, fsPromise, JSON) { | ||
| class Utils { | ||
|
|
||
| constructor() { | ||
| _bindAll(this, ['readFile', 'readJsonFile']); |
There was a problem hiding this comment.
Not called within an async method, so removing.
acolchado
commented
Apr 9, 2024
| module.exports = function (path, Promise, fsPromise, FixtureCache, Logger) { | ||
| class FixtureUtil { | ||
|
|
||
| constructor(fixturesPath) { | ||
| _bindAll(this, ['get', 'readAndProcessFile', 'startFileRead']); |
There was a problem hiding this comment.
Not called within an async method, so removing.
otrreeves
approved these changes
Apr 9, 2024
| @@ -1,9 +1,7 @@ | |||
| const _compact = require('lodash.compact'); | |||
| const _map = require('lodash.map'); | |||
| const _invokeMap = require('lodash.invokemap'); | |||
There was a problem hiding this comment.
I believe the _invokeMap usage in this file could be replaced with
return self._pluginInstances.map(plugin => plugin.end());Not sure if this is the only usage of _invokeMap though
There was a problem hiding this comment.
I believe so but it's not low-hanging fruit. I will take a look at it in the next set of PRs. Coverage is not great to catch is so I don't want to commit to writing additional tests and delaying the main need of the project right now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.