Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync package.xml with documentation: Add missing c-ares configure option #324

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

nberlee
Copy link
Contributor

@nberlee nberlee commented Aug 15, 2023

Brings the package.xml in line with what is
already documented, addressing the oversight
that c-ares was documented but not actually
available for configuration in the PECL
installation process.

nberlee and others added 2 commits August 15, 2023 15:47
Brings the package.xml in line with what is
already documented, addressing the oversight
that c-ares was documented but not actually
available for configuration in the PECL
installation process.

Signed-off-by: Nico Berlee <nico.berlee@on2it.net>
@doubaokun doubaokun merged commit 8958247 into openswoole:master Dec 8, 2023
10 checks passed
@SimonMacIntyre
Copy link

I think possibly this appears to be suddenly breaking our builds, since 22.1.1.

FROM php:8.2-fpm-alpine3.17 and installed with:

RUN install-php-extensions openswoole

Error output:

In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_channel_coro.cc:20:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.cc:1:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_client_coro.cc:17:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/swoole_atomic.cc:17:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_client.cc:17:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_coroutine_scheduler.cc:19:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/swoole_coroutine.cc:20:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
In file included from /tmp/pear/temp/openswoole/ext-src/php_swoole_cxx.h:19,
                 from /tmp/pear/temp/openswoole/ext-src/php_swoole.cc:16:
/tmp/pear/temp/openswoole/ext-src/php_swoole_private.h:92:2: error: #error "Enable c-ares support, require c-ares library"
   92 | #error "Enable c-ares support, require c-ares library"
      |  ^~~~~
/tmp/pear/temp/openswoole/ext-src/php_swoole.cc:36:10: fatal error: ares.h: No such file or directory
   36 | #include <ares.h>

@doubaokun
Copy link
Contributor

Pushed a fix: 22.1.2 and reverted this change. c-ares is automatically detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants