-
Notifications
You must be signed in to change notification settings - Fork 441
Feat/chunk ws payload #4660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Aaaaash
wants to merge
18
commits into
main
Choose a base branch
from
feat/chunk-ws-payload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+825
−152
Open
Feat/chunk ws payload #4660
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
2876b61
feat: send data by chunk in websocket
bytemain d46080a
feat: optimise performance
bytemain 1fdcb1d
fix: send
bytemain eb7c93e
test: update testcase
bytemain 7e5fafb
fix: treenode render
Aaaaash 5094e9b
fix: treenode render
Aaaaash f9f731a
fix: treenode render
Aaaaash 291af73
fix: improve promise syntax in frame decoder
Aaaaash b636208
chore: revert treenode change
Aaaaash 3bdda66
fix: refactor frame decoder tests to use async/await and improve read…
Aaaaash 855bd81
fix: enhance error handling in one-of serializer and improve message …
Aaaaash 113822e
fix: improve ws-channel test messages and enhance frame decoder proce…
Aaaaash a4540f3
chore: add testcase
Aaaaash 66f6716
chore: dispose logic
Aaaaash 4487a96
fix: test case
Aaaaash 198e6cd
fix: large file optimize
Aaaaash f82938d
refactor: update chunk size to 256KB and implement queue size limits …
Aaaaash 383a193
refactor: remove unused semantic highlighting option in large file op…
Aaaaash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
移除脆弱的性能断言
这里用
expect(duration).toBeLessThan(50)及expect(duration).toBeLessThan(1000)将单测绑死在极低延迟上,CI/本地机器一旦负载稍高就会随机失败。这类性能基准应放在基准测试或监控里,而不是功能性单测。建议改成只验证结果正确,或将性能检查移出单测流程。- expect(duration).toBeLessThan(50); expect(slice.byteLength).toBe(1024 * 1024);- expect(duration).toBeLessThan(1000);📝 Committable suggestion
🤖 Prompt for AI Agents