-
Notifications
You must be signed in to change notification settings - Fork 27
feat: optimize diff previewer #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Run and Debug this pull request in Codespaces |
WalkthroughWalkthrough此次更新主要集中在多个 Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant Server
participant DiffViewer
Client->>Server: 请求差异预览
Server->>DiffViewer: 生成差异预览
DiffViewer-->>Server: 返回预览结果
Server-->>Client: 响应差异预览
Recent review detailsConfiguration used: .coderabbit.yml Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
/next |
|
/next |
|
🎉 PR Next publish successful! 0.0.20240805065032-next.0 |
|
/next |
|
/next |
|
🎉 PR Next publish successful! 0.0.20240805081341-main.0 |
|
/next |
|
🎉 PR Next publish successful! 0.0.20240805084931-main.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (1)
packages/core/src/core/diff-viewer/module.ts (1)
1-5: 删除未使用的导入语句。
SumiReadableStream和InlineChatController已经被移除,但这里没有导入这些内容。确保所有导入的内容都在文件中使用。- import { Injectable } from '../../modules/opensumi__common-di'; - import { DiffViewerContribution } from './internal/base'; - import { DiffViewerThemeProvider } from './internal/theme.provider'; + import { Injectable } from '@opensumi/ide-core-common'; + import { DiffViewerContribution } from './internal/base'; + import { DiffViewerThemeProvider } from './internal/theme.provider';
|
/next |
|
🎉 PR Next publish successful! 0.0.20240805092414-featumi2.0 |
hacke2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types
Background or solution
ChangeLog
Summary by CodeRabbit
新特性
DiffViewerContribution类,增强了内联差异预览的功能和性能。修复