Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled selection of virtual nodes. #254

Merged

Conversation

Krakonos
Copy link
Member

@Krakonos Krakonos commented Aug 4, 2021

Virtual nodes are not proper nodes and most interactions don't work with
them and cause crashes or weird behavior. The only allowed action for
virtual node is the move interaction.

I am aware of two limitations:

  • Unless the option "Use separate move mode" is selected, virtual nodes cannot be moved (as selection is required in the combined mode)
  • Multiple virtual nodes cannot be moved at once (though I don't really see a use case for this).

This PR is a workaround for issue identified in PR #240, see more details in discussion to that PR.

Virtual nodes are not proper nodes and most interactions don't work with
them and cause crashes or weird behavior. The only allowed action for
virtual node is the move interaction.
@tunp
Copy link
Contributor

tunp commented Aug 5, 2021

Hi! I just tested it and it seems to work just like described for me.

@Krakonos
Copy link
Member Author

Thanks for testing, merging as a workaround for 0.19 release.

@Krakonos Krakonos merged commit 00b4827 into openstreetmap:master Aug 11, 2021
@Krakonos Krakonos added this to the 0.19.0 milestone Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants