Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create crossing/markings-BG.json #891

Merged
merged 19 commits into from
May 11, 2023
Merged

Create crossing/markings-BG.json #891

merged 19 commits into from
May 11, 2023

Conversation

Dimitar5555
Copy link
Contributor

Resolves #876

@github-actions
Copy link

🍱 Preview the tagging presets of this pull request here: https://pr-891--ideditor-presets-preview.netlify.app/id/dist/#locale=en.

@Dimitar5555
Copy link
Contributor Author

@tyrasd Any ideas why it's not working correctly? The screenshot is from a crossing in Bulgaria.

image

@Dimitar5555
Copy link
Contributor Author

At least the field shows now. Not sure why it's not the right one though..
image

@tyrasd
Copy link
Member

tyrasd commented May 5, 2023

Sorry for the late reply, but the issue you're seeing is caused by the regional field not specifying "autoSuggestions": false. In the autoSuggestions=true case (which is the default), iD will query taginfo for popular values of the tag and show those in addition to the supplied options.

@Dimitar5555
Copy link
Contributor Author

Thanks, it is working as intended now.
image

tyrasd added a commit to openstreetmap/iD that referenced this pull request May 11, 2023
@tyrasd
use all available option strings when setting value
d9c4d4a 
this fixes where tag values of fields with referenced strings can become corrupted when the sub-field has restricted `options`, and an unavailable option is entered manually into the field.

important for openstreetmap/id-tagging-schema#891
tyrasd added a commit to openstreetmap/iD that referenced this pull request May 11, 2023
@tyrasd
use all available option strings when setting value
a35653d 
this fixes where tag values of fields with referenced strings can become corrupted when the sub-field has restricted `options`, and an unavailable option is entered manually into the field.

important for openstreetmap/id-tagging-schema#891
@tyrasd tyrasd merged commit bc25be1 into openstreetmap:main May 11, 2023
tyrasd added a commit that referenced this pull request May 11, 2023
@tyrasd
include crossing:markings field in all crossing/*/traffic_signals pre…
57fe16f 
…sets

incl. the regional variant of it, see #891
@tyrasd
Copy link
Member

tyrasd commented May 11, 2023

Thanks!

PS: I noticed that the new regional field was not included in the */traffic_signals.json files. I assume that was an oversight, so I just added it in 57fe16f

@Dimitar5555 Dimitar5555 deleted the patch-1 branch May 11, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
regional
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide irrelevant crossing:markings values
2 participants
@Dimitar5555 @tyrasd