Add emergency=fire_service_inlet #806
Conversation
|
I don't know how to solve the conflicts. Can you tell me, what's missing? |
There was a problem hiding this comment.
The field fire_mains does not exist yet.1 You'd have to create the field in data/fields/fire_mains.json, in order to use it in the preset.
Footnotes
-
This produces the error in the build&test script, see https://github.com/openstreetmap/id-tagging-schema/actions/runs/4335474805/jobs/7570094016 ↩
|
PS: For reference: The tag was quite recently "approved" (see https://wiki.openstreetmap.org/w/index.php?oldid=2483791) |
Co-authored-by: Martin Raifer <martin@raifer.tech>
|
I think it should be fine now. |
data/fields/fire_mains.json
Outdated
| { | ||
| "key": "fire_mains", | ||
| "type": "combo", | ||
| "label": "Type", |
There was a problem hiding this comment.
I think we need to clarify that this Type is only supposed to represent the non-sprinkler part of the inlet. Maybe just calling it Riser Inlet (or Standpipe) would be better?!
There was a problem hiding this comment.
I think that is clear enough. emergency=fire_service_inlet is basically only about the inlet. So I think Riser Inlet or Standpipe would only lead to confusion.
There was a problem hiding this comment.
or maybe 'System-Type'?
There was a problem hiding this comment.
I changed it in Network-Type. I think this should be clear now.
tyrasd
dismissed
their stale review
requested changes look good, but further comments were made in the meantime which need to be clarified
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
Co-authored-by: Martin Raifer <martin@raifer.tech>
|
🍱 Preview the tagging presets of this pull request here: https://pr-806--ideditor-presets-preview.netlify.app/id/dist/#locale=en. |
Maybe there is a better icon for this.