-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more barrier presets #506
Conversation
Also added field for `maxwidth`
Co-authored-by: Martin Raifer <martin@raifer.tech>
* Remove `barrier=planter` preset * Add `planter_barrier` field which adds `barrier=planter` * Add `man_made=planter` preset with `planter_barrier` field
Because of this, I decided to change the preset to use |
That sounds like a good approach 👍 But could you please rename the field to |
This allows to show the "access" field if a man_made=planter vertex has also the barrier=planter tag.
I just noticed that, unfortunately, this approach doesn't allow us to show the |
9d3204d
to
49f529e
Compare
Good thinking, looks good to me |
"entrance" | ||
], | ||
"tags": { | ||
"barrier": "wicket_gate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this tag refer to the way the gate is constructed (small), its purpose (pedestrian access), or its location (secondary), or some combination? I’m finding the preset difficult to translate due to this ambiguity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand, the term refers only to a secondary gate for pedestrians near (or in1) a larger gate.
Footnotes
-
I would say that in OSM the
barrier=wicket_gate
probably only applies to the situation where the wicket is actually a separate entrance (as in this example), and not for wicket doors which are built directly into a large gate (example). The latter should probably be modeled as an attribute of the main gate (e.g.barrier=gate
+wicket=yes
), I assume. ↩
Perhaps it is better to rename it to something obvious like "Barrier (Fallen Tree)" rather than hide it from the search? As someone who surveys a lot of forests, this is a common item to add on paths. |
This PR adds presets for the following barriers listed on the wiki:
barrier=bump_gate
barrier=bus_trap
barrier=cable_barrier
barrier=full-height_turnstile
barrier=hampshire_gate
barrier=jersey_barrier
barrier=motorcycle_barrier
barrier=planter
barrier=rope
barrier=wicket_gate
I used the default barrier icon for most of these, but ideally those should get their own icons. For example,
barrier=jersey_barrier
could have an icon similar to this image depicting the general outline:The preset for
full-height_turnstile
could have an icon similar to the one used in OSM carto:Since the wiki article for
barrier=bus_trap
recommends also usingmaxwidth
, I created a field for it using the same field type used formaxheight
since their values are similar.I also added
barrier=ditch
,barrier=handrail
, andbarrier=log
as unsearchable presets. Forbarrier=ditch
,waterway=ditch
has a lot more uses and having making both of these searchable might be confusing for some users. The wiki article forbarrier=handrail
mentions that there's an "Unclear difference from fence". Althoughbarrier=log
is an approved tag, I made it unsearchable to prevent mappers from adding fallen trees that don't obstruct a passage.Closes #505